Skip to content

London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 4|IMPLEMENT_SHELL_TOOLS Python #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fatmaevin wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London|25-SDC-NOV| FATMA DEGIRMENCI | Sprint 4|IMPLEMENT_SHELL_TOOLS Python #289

fatmaevin wants to merge 6 commits into from
+112 −0

Conversation

@fatmaevin
Copy link

@fatmaevin fatmaevin commented Dec 8, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@fatmaevin fatmaevin added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 8, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 21, 2026
LonMcGregor
LonMcGregor reviewed Jan 21, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

implement-shell-tools/cat/cat.py Outdated
for line in f:
line_content = line.rstrip("\n")

if args.b and line_content != "":
Copy link

@LonMcGregor LonMcGregor Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see the duplication in these two branches of code. Is there some way to simplify this?

implement-shell-tools/wc/wc.py Outdated
if args.chars:
output.append(str(char_count))
output.append(args.file)
print("\t".join(output))
Copy link

@LonMcGregor LonMcGregor Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part at the end seems repeated. Is there something you could do to simplify this?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 21, 2026
@fatmaevin fatmaevin added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 2, 2026
LonMcGregor
LonMcGregor reviewed Feb 3, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this is almost complete. Have you tried running wc with a wildcard option? Does it work correctly?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@fatmaevin
Copy link
Author

fatmaevin commented Feb 9, 2026

I tested my program using wildcards (e.g. sample-files/*.txt). To fix this issue, I updated argparse to use nargs="+", which allows the program to accept multiple file arguments. I then iterated over the files and re-tested the program. It now correctly processes wildcard inputs.

@fatmaevin fatmaevin added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
@LonMcGregor
Copy link

LonMcGregor commented Feb 9, 2026

The wc program is now processing individual multiple inputs, but can you see what is missing in your implementation compared to the output of the original wc program?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
@fatmaevin fatmaevin added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 4 Assigned during Sprint 4 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fatmaevin @LonMcGregor